[Webkit-unassigned] [Bug 228319] Geolocation API should callback with error if doc is not fully active

Mon Aug 23 17:07:48 PDT 2021

https://bugs.webkit.org/show_bug.cgi?id=228319

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #2)
> There are quite a few issues causing the new test not to run, besides
> Geolocation issues:
> - Lack of a <body> even though the test relies on document.body
> - After re-adding the iframe to the document, it does:
> ```
> document.body.appendChild(iframe);
>     iframe.contentWindow.opener = window;
>     await new Promise((resolve) =>
>       window.addEventListener("load", resolve, { once: true })
>     );
> ```
> 
> I think this should be:
> ```
> document.body.appendChild(iframe);
>     iframe.contentWindow.opener = window;
>     await new Promise((resolve) =>
>       iframe.addEventListener("load", resolve, { once: true })
>     );
> ```
> 
> Why would the main frame's load event fire again?

And I think we need this test change too:
-    assert_true(position, "Expected a position");
+    assert_true(Boolean(position), "Expected a position");

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210824/22fbd73d/attachment.htm>