[Webkit-unassigned] [Bug 228122] Add functionalities for parsing URL query string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228122

--- Comment #40 from John Wilander <wilander at apple.com> ---
(In reply to Alex Christensen from comment #39)
> Comment on attachment 434864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434864&action=review
> 
> Some post-commit feedback:
> 
> > Source/WTF/wtf/URL.cpp:1225
> > +static StringView substringIgnoringQueryAndFragments(const URL& url)
> 
> Could you move this to be a lambda inside isEqualIgnoringQueryAndFragments? 
> It's only used in that scope.
> 
> > Source/WTF/wtf/URL.h:248
> > +WTF_EXPORT_PRIVATE bool isEqualIgnoringQueryAndFragments(const URL&, const URL&);
> 
> I think this should either be renamed to areEqualIgnoringQueriesAndFragments
> or it should be made a member of the URL class.
> bool equalsIgnoringQueryAndFragment(const URL&) const;
> 
> > Source/WTF/wtf/URL.h:249
> > +WTF_EXPORT_PRIVATE void removeQueryParameters(URL&, const HashSet<String>&);
> 
> Could you add another important test case to verify that we don't regress
> behavior in the future?
> Make a URL from "https://example.com/?%C3%A4=value"
> See how removing "%C3%A4" changes the URL.
> See how removing "ä" changes the URL.
> 
> I think rather than passing a non-const URL as a parameter, this should be a
> member of the URL class.
> void removeQueryParametersWithKeys(const HashSet<String>& keys);

Could you file follow-up Bugzillas, please? I can do it too if you're short on time. I just don't want us to lose these valuable enhancements.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210823/2f3b85c2/attachment.htm>