[Webkit-unassigned] [Bug 228363] [Win][Uniscribe] Implement Font::applyTransforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228363

--- Comment #10 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 436142
  --> https://bugs.webkit.org/attachment.cgi?id=436142
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436142&action=review

>> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:277
>> +GlyphBufferAdvance Font::applyTransforms(GlyphBuffer& glyphBuffer, unsigned beginningGlyphIndex, unsigned beginningStringIndex, unsigned stringLength, bool enableKerning, bool requiresShaping, const AtomString& locale, StringView text, TextDirection textDirection) const
> 
> This should probably move to a different file. Is there a FontUniscribe.cpp or FontWin.cpp? If not, we should probably make one.

Will we deprecate ComplexTextController soon?
If so, it will be easy to move Font::applyTransforms elsewhere after that.

Because Font::applyTransforms is a almost copy of
ComplexTextController::collectComplexTextRunsForCharacters, I
want to put them in a same file.

One idea is adding a new function applyTransformsByUniscribe in ComplexTextControllerUniscribe.cpp,
moving Font::applyTransforms to FontWin.cpp.

> GlyphBufferAdvance Font::applyTransforms(GlyphBuffer& glyphBuffer, unsigned beginningGlyphIndex, unsigned beginningStringIndex, unsigned stringLength, bool enableKerning, bool requiresShaping, const AtomString& locale, StringView text, TextDirection textDirection) const
> {
>    return applyTransformsByUniscribe(glyphBuffer, beginningGlyphIndex, beginningStringIndex, stringLength, enableKerning, requiresShaping, locale, tesxt, textDirection);
> }

However, this doesn't look a nice idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210823/a05e0e6e/attachment.htm>