[Webkit-unassigned] [Bug 229128] New: [Metal ANGLE] Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leaks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 15 19:46:45 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=229128

            Bug ID: 229128
           Summary: [Metal ANGLE] Fix over-autorelease of
                    rx::DisplayMtl::getMetalDeviceMatchingAttribute() and
                    various Objective-C leaks
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: ANGLE
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: dino at apple.com, kbr at google.com, kkinnunen at apple.com

Fix over-autorelease of rx::DisplayMtl::getMetalDeviceMatchingAttribute() and various Objective-C leaks.

The clang static analyzer flags several leaks in Metal ANGLE code, and I noticed an over-autorelease of the return value of rx::DisplayMtl::getMetalDeviceMatchingAttribute() in the process.

To make this easier/cleaner to fix, I wrote an rx::mtl::adoptObjCObj<>() helper function, which was modeled after WTF::RetainPtr<> in WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210816/e1dc2839/attachment.htm>


More information about the webkit-unassigned mailing list