[Webkit-unassigned] [Bug 229032] [GTK] Simplify TestWebKitAccessibility

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 06:26:38 PDT 2021


Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at gnome.org
 Attachment #435414|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 435414
  --> https://bugs.webkit.org/attachment.cgi?id=435414

View in context: https://bugs.webkit.org/attachment.cgi?id=435414&action=review

Heh, nice!

> Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:41
> +        // We can get warnings from atspi when trying to connect to applications.
> +        Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
>          int childCount = atspi_accessible_get_child_count(desktop.get(), nullptr);
> +        Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);

What sort of warnings?

Certainly not failing the test is good to do, but they probably pollute the test log, don't they?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210812/b7c13676/attachment.htm>

More information about the webkit-unassigned mailing list