[Webkit-unassigned] [Bug 228285] [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 10 16:37:44 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=228285

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
> --- /Volumes/Data/worker/ios-simulator-14-debug-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-002-expected.txt
> +++ /Volumes/Data/worker/ios-simulator-14-debug-tests-wk2/build/layout-test-results/editing/pasteboard/smart-paste-paragraph-002-actual.txt
> @@ -2,8 +2,6 @@
>  EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
>  EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
>  EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > BODY > HTML > #document to 0 of PRE > BODY > HTML > #document toDOMRange:range from 0 of PRE > BODY > HTML > #document to 0 of PRE > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > BODY > HTML > #document to 0 of PRE > BODY > HTML > #document toDOMRange:range from 0 of #text > SPAN > PRE > BODY > HTML > #document to 4 of #text > SPAN > PRE > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification

This failure output is consistent with what happens if you turn the synthesized double tap in `selectWordByDoubleTapOrClick` into just a single tap, like so:

```
diff --git a/LayoutTests/resources/ui-helper.js b/LayoutTests/resources/ui-helper.js
index 1ebe1c78b8c1..0285d741910b 100644
--- a/LayoutTests/resources/ui-helper.js
+++ b/LayoutTests/resources/ui-helper.js
@@ -335,7 +335,7 @@ window.UIHelper = class UIHelper {
         const y = boundingRect.y + relativeY;
         if (this.isIOSFamily()) {
             await UIHelper.activateAndWaitForInputSessionAt(x, y);
-            await UIHelper.doubleTapAt(x, y);
+            await UIHelper.activateAt(x, y);
             // This is only here to deal with async/sync copy/paste calls, so
             // once <rdar://problem/16207002> is resolved, should be able to remove for faster tests.
             await new Promise(resolve => testRunner.runUIScript("uiController.uiScriptComplete()", resolve));
```

This suggests that when these tests fail, they fail because `UIHelper.doubleTapAt` is, for some reason, only resulting in a single tap.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210810/f454b4ad/attachment.htm>


More information about the webkit-unassigned mailing list