[Webkit-unassigned] [Bug 228735] REGRESSION(r279050): Crash under CSSImageValue::createDeprecatedCSSOMWrapper with cursor images

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 3 18:48:55 PDT 2021


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 434824
  --> https://bugs.webkit.org/attachment.cgi?id=434824

View in context: https://bugs.webkit.org/attachment.cgi?id=434824&action=review

> Source/WebCore/css/CSSValue.cpp:498
> +    if (isImageValue())
>          return downcast<CSSImageValue>(this)->createDeprecatedCSSOMWrapper(styleDeclaration);
>      if (isPrimitiveValue())

Occurs to me that we could come back here and make this more obviously correct by using is<CSSImageValue>, is<CSSPrimitiveValue>, and is<CSSValueList>.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210804/5dca0bd2/attachment.htm>

More information about the webkit-unassigned mailing list