[Webkit-unassigned] [Bug 228122] Add functionalities for parsing URL query string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228122

--- Comment #32 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 434848
  --> https://bugs.webkit.org/attachment.cgi?id=434848
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434848&action=review

>> Source/WTF/wtf/URL.cpp:1173
>> +        return { };
> 
> Not 100% sure this is the best behavior if only one of the URLs is invalid. Depends on how we intend to use these functions.
> 
> Tests should cover this behavior.

I think invalid URLs' queries are empty StringViews, so this is just a performance optimization which is probably unnecessary.

>> Source/WTF/wtf/URL.cpp:1190
>> +    auto comparesLessThan = [&compare] (const KeyValuePair<String, String>& a, const KeyValuePair<String, String>& b) {
> 
> I suspect just [compare] would be fine, don’t necessarily need [&compare].

or [&]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210803/1a9bf277/attachment.htm>