[Webkit-unassigned] [Bug 228270] Elements cloned into an iframe cannot be accessed by webdriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228270

--- Comment #7 from MoLow <moshe at atlow.co.il> ---
(In reply to Sam Sneddon [:gsnedders] from comment #3)
> Comment on attachment 434175 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434175&action=review
> 
> (Non-reviewer r-)
> 
> > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js:213
> > +          (value.nodeType == NodeType.ELEMENT || value.nodeType == NodeType.DOCUMENT || value instanceof ShadowRoot);
> 
> The "value instanceof ShadowRoot" check still suffers from the exact same
> problem as described above.
> 
> My suggestion here would be something like:
> 
> let constructor = value.constructor;
> do {
>     if (constructor.name === "Element") return true;
> } while(constructor = Object.getPrototypeOf(constructor));
> return false;
> 
> (With whatever else is needed to make that safe, not thought too much about
> this! Still need to check that value is a non-null object, at least.)
> 
> Also: per spec this is just used by
> https://w3c.github.io/webdriver/#dfn-internal-json-clone-algorithm, and in
> that case per spec we simply want to check if its an instanceof Element; so
> do we even want to allow other Nodes?

I have added a fix for shadow root - in a somwhat more performant way

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210803/04b2dbb4/attachment.htm>