[Webkit-unassigned] [Bug 228156] macOS key-driven smooth scrolling does not work for pageUp/pageDown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228156

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorton at apple.com

--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434785
  --> https://bugs.webkit.org/attachment.cgi?id=434785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434785&action=review

> Source/WebCore/ChangeLog:10
> +        No tests yet.

Maybe this is a good opportunity to start porting the iOS keyboard scrolling tests? I think there is one specifically about pageUp/Down

> Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:269
> +        [self.nextResponder tryToPerform:_cmd with:sender];

I think you need to return here, not say that you're not handling it (by passing it to the next responder) while ALSO handling it :)

> Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:277
> +        [self.nextResponder tryToPerform:_cmd with:sender];

(and here)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210802/6715d0e0/attachment-0001.htm>