[Webkit-unassigned] [Bug 189513] Wrong static position for out-of-flow positioned element with different writing-mode than its containing block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189513

--- Comment #5 from zsun at igalia.com ---
(In reply to Sergio Villar Senin from comment #3)
> Comment on attachment 427332 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427332&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:3997
> > +            staticLogicalTop += child->isHorizontalWritingMode() ? staticLogicalTop : renderBox.logicalLeft();
> 
> Shouldn't it be "? renderBox.logicalTop() : renderBox.logicalLeft()" ?

Yes. It should be. I must have pressed wrong button while view my changes locally... Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210429/2b2699dc/attachment.htm>