[Webkit-unassigned] [Bug 225144] External hole punch player not working on WPE Webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225144

Miguel Gomez <magomez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magomez at igalia.com

--- Comment #2 from Miguel Gomez <magomez at igalia.com> ---

> Tools/gtk/install-dependencies
> Tools/Scripts/update-webkitgtk-libs
> Tools/Scripts/build-webkit --gtk --debug

You are building the gtk port

> diff --git a/Source/cmake/OptionsWPE.cmake b/Source/cmake/OptionsWPE.cmake
> index d8c2c251f3ea..9ca42847ca36 100644
> --- a/Source/cmake/OptionsWPE.cmake
> +++ b/Source/cmake/OptionsWPE.cmake
> @@ -80,7 +80,7 @@ WEBKIT_OPTION_DEFINE(USE_LCMS "Whether to enable support
> for image color managem
>  
>  # Private options specific to the WPE port.
>  WEBKIT_OPTION_DEFINE(USE_GSTREAMER_HOLEPUNCH "Whether to enable GStreamer
> holepunch" PRIVATE OFF)
> -WEBKIT_OPTION_DEFINE(USE_EXTERNAL_HOLEPUNCH "Whether to enable external
> holepunch" PRIVATE OFF)
> +WEBKIT_OPTION_DEFINE(USE_EXTERNAL_HOLEPUNCH "Whether to enable external
> holepunch" PRIVATE ON)
>  

But you enabled the holepunch option for the wpe port, so you're not really using it, and what you're getting is a video player with a content that can't be played.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210428/9896d221/attachment.htm>