[Webkit-unassigned] [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225099

--- Comment #11 from Mark Lam <mark.lam at apple.com> ---
(In reply to Daniel Kolesa from comment #10)
> (In reply to Mark Lam from comment #9)
> > Can't you add this in PlatformUse.h:
> > 
> > #if OS(LINUX) && !defined(__BIONIC__) && !defined(__GLIBC__)
> > #define USE_MUSL
> > #endif
> > 
> > ... and check USE(MUSL) in all the places instead?  That is unless you
> > intend to use this code for other than musl.  Anyway, I just think it's
> > error prone to always have a long string of conditionals like that that
> > needs to be copy-pasted to multiple places.  That's my $.02.
> 
> that won't be true, because that doesn't check for musl, it checks for every
> c library except glibc and bionic (so also e.g. uclibc and so on)
> 
> as i said, the best thing would probably be to use the the code universally,
> without checking which libc it is; it should work everywhere as is, so there
> is no need to check for libc here

SGTM.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210427/89ab9cd2/attachment.htm>