[Webkit-unassigned] [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225099

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #427144|review?                     |review+
              Flags|                            |

--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 427144
  --> https://bugs.webkit.org/attachment.cgi?id=427144
fixed style, typos

View in context: https://bugs.webkit.org/attachment.cgi?id=427144&action=review

r=me with suggestion for USE(MUSL).  Feel free to do that as clean up in a follow up patch.

> Source/WTF/wtf/StackBounds.cpp:117
> +#if OS(LINUX) && !defined(__BIONIC__) && !defined(__GLIBC__)

I see this set of conditionals used in more than 1 place (3 in this patch).  Would it be better to define USE_MUSL in PlatformUse.h and check #if USE(MUSL) here (and in the other places)?  Is this code only needed for musl?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210427/979e82c3/attachment.htm>