[Webkit-unassigned] [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225099

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 427144
  --> https://bugs.webkit.org/attachment.cgi?id=427144
fixed style, typos

Nice one, thanks!

Patch LGTM, but I also think it would be positive to remove conditional compilation
guards and use the same code with the different libcs; to avoid having one code path
less exercised than the others.

I will try to get some JSC developer to also take a look at this and give the
final r+; it seems like a good idea to have another pair of eyes go over this
patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427144&action=review

> Source/WTF/wtf/StackBounds.cpp:125
> +    if (getpid() == static_cast<pid_t>(syscall(SYS_gettid))) {

I would be in favor of moving this check into a Linux-specific implementation of
WTF::isMainThread(). Currently Linux uses the implementation from MainThreadGeneric.cpp
but pthread_main_np() is not available on Linux, so if something attempts to use it
before a call to WTF::initializeThreadPlatform() has been made e.g. constructors it
will most certainly return “false” because the “mainThread” variable would have not
been yet initialized.

Nevertheless, I think that could be in a follow-up patch, and unless somebody has
a different opinion, should not block landing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210427/f16c7337/attachment.htm>