[Webkit-unassigned] [Bug 225099] [WPE][GTK] More correct fixes for stack size issues on musl libc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225099

Daniel Kolesa <dkolesa at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #427141|                            |review?
              Flags|                            |

--- Comment #1 from Daniel Kolesa <dkolesa at igalia.com> ---
Created attachment 427141

  --> https://bugs.webkit.org/attachment.cgi?id=427141&action=review

patch

Some comments for potential review:

- I considered using WTF::isMainThread() but decided against it; since this piece of code is specific to Linux, I thought it'd be best to use the lowest level API in order to avoid abstractions potentially causing issues and stay robust
- Ideally I'd like to change the '#if OS(LINUX) && !defined(__BIONIC__) && !defined(__GLIBC__)' to just '#if OS(LINUX)' in StackBounds.cpp. Common paths are better tested, and this should not hurt non-musl systems; finally, fewer ifdefs are better than more. I included a strict conditional for now to be conservative. I'll leave it up to reviewer which path we'll end up taking.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210427/63f3179d/attachment.htm>