[Webkit-unassigned] [Bug 225048] Refcount Style::Resolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225048

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rniwa at webkit.org
 Attachment #427032|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427032
  --> https://bugs.webkit.org/attachment.cgi?id=427032
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427032&action=review

> Source/WebCore/style/StyleResolver.h:83
> +class Resolver : public RefCounted<Resolver> {
>  public:

Should we iso-heap this?

> Source/WebCore/style/StyleScope.h:180
>      HashSet<const Element*> m_elementsInHeadWithPendingSheets;
>      HashSet<const Element*> m_elementsInBodyWithPendingSheets;

Yikes. We should use WeakHashSet for these!

> Source/WebCore/style/StyleTreeResolver.h:73
>          Scope* enclosingScope { nullptr };

Should this be RefPtr<Scope> as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210426/221bbd25/attachment.htm>