[Webkit-unassigned] [Bug 225011] [Metal ANGLE] support primitive restart behavior with simple data types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225011

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #426973|review?                     |review+
              Flags|                            |

--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 426973
  --> https://bugs.webkit.org/attachment.cgi?id=426973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426973&action=review

> Source/ThirdParty/ANGLE/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=225011

Could you add the radar link in here?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:418
> +    T *bufferData = (T*)(idxBuffer->mapReadOnly(ctx));

I'm not sure of ANGLE style, but wouldn't this be better as:

auto* bufferData = static_cast<T*>(idxBuffer->mapReadOnly(ctx));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210425/5d32e8c9/attachment.htm>