[Webkit-unassigned] [Bug 224941] Crash in BreakBlockquoteCommand::doApply()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224941

--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 426945
  --> https://bugs.webkit.org/attachment.cgi?id=426945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426945&action=review

>> Source/WebCore/editing/BreakBlockquoteCommand.cpp:112
>> +            if (auto nextNode = NodeTraversal::next(*startNode))
> 
> This is a bit misleading. This should be either auto* or we should be calling makeRefPtr & WTFMove(nextNode) below

This is an interesting new coding style idea/rule that I have never heard before.

I often use auto for types that are raw pointers. I know some people prefer using auto*, but this is not a preference I share.

Ryosuke, are you going even further and suggesting that, due to the risk of thinking that something is a safer smart pointer, we should have a style rule to never use "auto" for a raw pointer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210424/4b5dbe8d/attachment.htm>