[Webkit-unassigned] [Bug 224941] Crash in BreakBlockquoteCommand::doApply()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224941

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #426945|review?                     |review+
              Flags|                            |

--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 426945
  --> https://bugs.webkit.org/attachment.cgi?id=426945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426945&action=review

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:112
> +            if (auto nextNode = NodeTraversal::next(*startNode))

This is a bit misleading. This should be either auto* or we should be calling makeRefPtr & WTFMove(nextNode) below

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:117
> +        if (auto child = startNode->traverseToChildAt(pos.deprecatedEditingOffset()))

Ditto.

> Source/WebCore/editing/BreakBlockquoteCommand.cpp:119
> +        else if (auto next = NodeTraversal::next(*startNode))

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210424/6cc01ab7/attachment-0001.htm>