[Webkit-unassigned] [Bug 224991] [Metal ANGLE] Temporarily remove AST validation even for debug builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 14:09:44 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=224991

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #426937|review?                     |review+
              Flags|                            |

--- Comment #6 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 426937
  --> https://bugs.webkit.org/attachment.cgi?id=426937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426937&action=review

Thanks for the explanation. r+

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm:88
> +#if defined(ANGLE_ENABLE_ASSERTS) && 0

Please add some TODO here regarding moving this validation in the future so we don't forget it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210423/3d52d23d/attachment-0001.htm>


More information about the webkit-unassigned mailing list