[Webkit-unassigned] [Bug 222885] Formalize rules for what is an Experimental Feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222885

--- Comment #29 from Maciej Stachowiak <mjs at apple.com> ---
(In reply to Ryosuke Niwa from comment #26)
> (In reply to Maciej Stachowiak from comment #25)
>
> > 
> > I like distinguishing "option" flags from "feature" flags, but maybe we
> > could try for something easy to type/read in config files. Maybe we don't
> > need the word Enabled in all places, and perhaps these phrases could be all
> > lowercase.
> 
> I don't think we necessarily need to type in these names. We could either
> put a new field in yaml like below or just put debugging options and feature
> flags in two different files. It's really confusing now that WebPreferences
> list both the list of features as well as things we only disable or enable
> for debugging purposes. That's a lot more important distinction than whether
> a given feature is being tested vs. experimental to me.
> 
> AsyncClipboardAPIEnabled:
>   type: bool
>   kind: feature
>   state: stable
>   humanReadableName: "Async Clipboard API"
>   humanReadableDescription: "Enable the async clipboard API"
>   defaultValue:
> ...
> 
> WebGL2Enabled:
>   type: bool
>   kind: feature
>   state: experimental
>   humanReadableName: "WebGL 2.0"
>   humanReadableDescription: "WebGL 2 prototype"
>   webcoreBinding: RuntimeEnabledFeatures
>   condition: ENABLE(WEBGL2)
>   defaultValue:
> ...
> 
> RequestIdleCallbackEnabled:
>   type: bool
>   kind: feature
>   state: untested
>   humanReadableName: "requestIdleCallback"
>   humanReadableDescription: "Enable requestIdleCallback support"
>   defaultValue:
> ...
> 
> TextAreasAreResizable:
>   type: bool
>   kind: internal.debug
>   webcoreOnChange: setNeedsRecalcStyleInAllFrames
>   defaultValue:
> ...

Reasonable direction but I'm not sure I like having both "kind" and "State" fields (especially since, in this example, state does not apply to option/debugging flags at all, and instead they say everything in the state.

Is the dot syntax because yaml doesn't allow spaces (without quotes) in the value field?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210422/453b96e7/attachment.htm>