[Webkit-unassigned] [Bug 224934] [css-flexbox] Table layout disregards overriding width

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224934

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |svillar at igalia.com
 Attachment #426821|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 426821
  --> https://bugs.webkit.org/attachment.cgi?id=426821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426821&action=review

> Source/WebCore/ChangeLog:18
> +        Give precedence to the element's overriding width if it has been set, instead of discarding it

Super nit: we normally start writing the comment just after the semicolon, so move part of this description to the above line.

> Source/WebCore/ChangeLog:20
> +        (WebCore::RenderTable::computePreferredLogicalWidths):

Ditto.

> Source/WebCore/rendering/AutoTableLayout.cpp:287
> +        if (tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive())

You can now write this in a single line like this:

else if (auto tableLogicalWidth = m_table->style().logicalWidth(); tableLogicalWidth.isFixed() && tableLogicalWidth.isPositive())

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210422/7a7e0e16/attachment.htm>