[Webkit-unassigned] [Bug 224538] [css-grid] last-baseline shouldn't affect baseline alignment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224538

Javier Fernandez <jfernandez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #426665|                            |review+
              Flags|                            |

--- Comment #12 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 426665
  --> https://bugs.webkit.org/attachment.cgi?id=426665
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426665&action=review

r=me

> Source/WebCore/rendering/RenderGrid.cpp:1246
> +    bool isBaseline = allowed == FirstLine? isFirstBaselinePosition(align) : isBaselinePosition(align);

nit: there must be a space between FirstLine and the "?" symbol.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210421/b94cb8f6/attachment.htm>