[Webkit-unassigned] [Bug 224538] [css-grid] last-baseline shouldn't affect baseline alignment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224538

--- Comment #9 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 426539
  --> https://bugs.webkit.org/attachment.cgi?id=426539
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426539&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1236
> +bool RenderGrid::isBaselineAlignmentForChild(const RenderBox& child, F isBaseline) const

As we discussed privately, perhaps this approach is not the ideal one. We can achieve the same using an enumeration instead of the function argument, so that we can figure whether first baseline, last baseline or both are valid values. 
We can define the new argument to default to "both", which is the common case and it'd avoid to change any of the other callers. What do you think ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210420/d773d8d1/attachment.htm>