[Webkit-unassigned] [Bug 224665] [css-flexbox] Tables as flex items should follow their overriding height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224665

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #426213|review?                     |review+
              Flags|                            |

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 426213
  --> https://bugs.webkit.org/attachment.cgi?id=426213
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426213&action=review

Looks good to me. I wonder, does it not fix any grid-layout width tables bug?

> Source/WebCore/ChangeLog:3
> +        Table layout takes overriding height into account

This is a nit, but bug title normally describes the issue and...

> Source/WebCore/ChangeLog:8
> +        RenderTable::layout applies the overriding height set by the element's parent.

ChangeLog body describes the fix. Don't be afraid to be verbose :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210416/083156b7/attachment.htm>