[Webkit-unassigned] [Bug 221473] [css-flexbox] Tables as flex items issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221473

--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 426208
  --> https://bugs.webkit.org/attachment.cgi?id=426208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426208&action=review

Thanks for the patch!

Every patch to WebKit needs a test. If this is covered by WPT tests then you need to remove them from TestExpectations file.

> Source/WebCore/rendering/RenderTable.cpp:513
> +            for (unsigned i = 0; i < m_captions.size(); ++i) {

You can write this like

for (auto& caption : m_captions)

> Source/WebCore/rendering/RenderTable.cpp:517
> +            LayoutUnit contentOverridingLogicalHeight = overridingLogicalHeight() - captionLogicalHeight;

Not sure why you label this as contentOverridingLogicalHeight. overridingLogicalHeight() refers to the border box, meaning that it includes border and padding so if you really want the content height you have to use overridingContentLogicalHeight()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210416/a3cde114/attachment.htm>