[Webkit-unassigned] [Bug 224538] [css-grid] last-baseline shouldn't affect baseline alignment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224538

--- Comment #4 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #2)
> Comment on attachment 426028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426028&action=review
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1246
> > +    return isBaselinePosition(align) && align != ItemPosition::LastBaseline && !hasAutoMargins;
> 
> I don't think this is correct. The purpose of this function was to determine
> whether a grid item has or not a value for the CSS Box Alignment properties
> that may imply it participates in baseline alignment (this would depend on
> other factors too). Hence, last-baseline is a valid value for this purpose.
> 
> If I've understood the CSS WG resolution, what we want is to prevent
> last-baseline to affect how we compute the grid container's baseline, which
> the algorithm described in the spec states that we should consider grid
> items participating in baseline alignment "along the first row". That indeed
> implies excluding items with last-baseline value, but only for this specific
> purpose. 
> 
> I'd rather add the logic to exclude the last-baseline value as part of the
> algorithm implemented in  RenderGrid::firstLineBaseline.

Code updated. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210416/0af550d8/attachment.htm>