[Webkit-unassigned] [Bug 224650] New: Web Inspector: audit for re-entrancy issues with `initialLayout` and `layout`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 23:16:50 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=224650

            Bug ID: 224650
           Summary: Web Inspector: audit for re-entrancy issues with
                    `initialLayout` and `layout`
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

It appears that it's possible for re-entrancy issues in the `WI.View` system since the `_didInitialLayout` flag isn't set until _after_ `initialLayout` returns, meaning that if the logic inside `initialLayout` triggers a synchronous `layout` then that second `layout` won't know that it's already in the middle of an `initialLayout`.

As an example, showing the `WI.GraphicsOverviewContentView` in `WI.GraphicsTabContentView.prototype.initialLayout` causes the navigation sidebar to be shown, which forces a synchronous `layout` from handling `WI.Sidebar.Event.WidthDidChange`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210416/242c98ea/attachment-0001.htm>


More information about the webkit-unassigned mailing list