[Webkit-unassigned] [Bug 224587] Crash in ReplaceSelectionCommand::mergeEndIfNeeded()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 10:58:23 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=224587

--- Comment #4 from Julian Gonzalez <julian_a_gonzalez at apple.com> ---
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 426069 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426069&action=review
> 
> > Source/WebCore/editing/ReplaceSelectionCommand.cpp:984
> > +    if (startOfInsertedContent.isNull() || endOfInsertedContent.isNull())
> 
> Can we add this assertion here?
> ASSERT(startOfInsertedContent.isNull() == endOfInsertedContent.isNull());

Above the if? (i.e. unconditionally?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210415/c4b80109/attachment.htm>


More information about the webkit-unassigned mailing list