[Webkit-unassigned] [Bug 224603] New: MacCatalyst WTF HAVE_PDFKIT is not in sync with HAVE_PDFKIT in TestWebKitAPI, build failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224603

            Bug ID: 224603
           Summary: MacCatalyst WTF HAVE_PDFKIT is not in sync with
                    HAVE_PDFKIT in TestWebKitAPI, build failure
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kkinnunen at apple.com
                CC: thorton at apple.com
        Depends on: 222643
            Blocks: 224602

MacCatalyst WTF HAVE_PDFKIT is not in sync with HAVE_PDFKIT in TestWebKitAPI

Breaks link due to missing symbol that is used in TestPDFDocument.m

        ASSERT([m_annotation.get().action isKindOfClass:[PDFActionURL class]]);

(PDFActionURL is missing.
Before regressing in bug 22643, MacCatalyst did not build the test. 
After regressing in bug 22643, MacCatalyst tries to build the test and fails.

The error is silent, since the pattern of defining HAVE_* is that we don't ever define 0. Thus we inherit HAVE_PDFKIT from WTF, even though it's (semantically) not what was intended.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=222643
[Bug 222643] Modernize WebKit2 PDFKit softlinking
https://bugs.webkit.org/show_bug.cgi?id=224602
[Bug 224602] MacCatalyst ANGLE is linked with @loader_path/../../../libANGLE-shared.dylib
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210415/96d6a3f8/attachment-0001.htm>