[Webkit-unassigned] [Bug 224497] New: [build.webkit.org] run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 13 11:29:43 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=224497

            Bug ID: 224497
           Summary: [build.webkit.org] run-javascriptcore-tests should
                    report commit identifier instead of svn revision to
                    results.webkit.org
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

On build.webkit.org run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org.

Current logic seems to be finding the revision/hash using commitForDirectory() method in https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/VCSUtils.pm#L382. We can update that logic to return commit identifier.

Other options are:
- run-javascriptcore-tests script can accept a parameter named commit-identifier/ref and buildbot can pass that parameter based on 'identifier' build property.
- do nothing, when we move build.webkit.org bots to git, run-javascriptcore-tests will start reporting git hash to results.webkit.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210413/9e700a1e/attachment.htm>


More information about the webkit-unassigned mailing list