[Webkit-unassigned] [Bug 224390] [CoreIPC] Crash in logDiagnosticMessage code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224390

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #425803|review?                     |review-
              Flags|                            |

--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425803
  --> https://bugs.webkit.org/attachment.cgi?id=425803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425803&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:428
> +        || decoder.messageName() == Messages::WebPageProxy::LogDiagnosticMessageFromWebProcess::name()

That's not quite right. You'll need to provide implementations for these logging functions on ProvisionalPageProxy which do the MESSAGE_CHECKS with m_process and THEN call the public logging functions on WebPageProxy. This is important because WebPageProxy and ProvisionalPageProxy use different processes. You wouldn't want a bad IPC from the provisional process to kill the committed process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210412/83722513/attachment.htm>