[Webkit-unassigned] [Bug 223504] [css-grid] Set hasIntrinsicWidth & hasIntrinsicHeight properties for SVG element's intrinsic size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223504

--- Comment #7 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 425275
  --> https://bugs.webkit.org/attachment.cgi?id=425275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425275&action=review

r=me

> Source/WebCore/rendering/RenderReplaced.cpp:630
> +    bool hasIntrinsicHeight = constrainedSize.hasIntrinsicHeight || constrainedSize.height() > 0;

I'd suggest a comment here to note that we are only updating the hasIntrinsicHeight flag for SVG elements, but that ideally, we would like to use it in all the cases and get rid of the constrainedSize.height() > 0 clause.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210409/6004bb6d/attachment.htm>