[Webkit-unassigned] [Bug 224237] New: [GStreamer] At EOS, change position to match duration, not the other way around.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 6 08:12:26 PDT 2021
https://bugs.webkit.org/show_bug.cgi?id=224237
Bug ID: 224237
Summary: [GStreamer] At EOS, change position to match duration,
not the other way around.
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebKitGTK
Assignee: webkit-unassigned at lists.webkit.org
Reporter: aboya at igalia.com
CC: bugs-noreply at webkitgtk.org
The criteria used to check if playback has finished is currentTime >=
duration. Currently MediaPlayerPrivateGStreamer::didEnd() ensures this
in an awkward way: by changing the duration so that it matches
currentTime, rather than the other way around.
This meant a duration change at the end of playback most of the time,
with a slightly different duration each time, since currentTime is
cached periodically.
This patch reworks that function to work more naturally and less racy:
First, only if the stream doesn't have a set duration (e.g. live
stream), we set a duration to currentTime, as defined in the spec.
Second, at EOS we update currentTime to match duration, rather than
the other way around.
This patch doesn't introduce changes in test results.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210406/28bcd4c2/attachment.htm>
More information about the webkit-unassigned
mailing list