[Webkit-unassigned] [Bug 224159] New: Wasted vector capacity in MatchResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224159

            Bug ID: 224159
           Summary: Wasted vector capacity in MatchResult
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

With the patch from bug 186698 and loading nytimes article pages, we see wasted vector capacity under MatchResult:

Wasted capacity: 12144 bytes (used 992 of 13136 bytes, utilization: 7.55%) - 55 allocations
5   0x3ddd1abb2 WTF::VectorBuffer<WebCore::Style::MatchedProperties, 0ul, WTF::FastMalloc>::VectorBuffer(unsigned long, unsigned long)
6   0x3ddd1aa65 WTF::Vector<WebCore::Style::MatchedProperties, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector(WTF::Vector<WebCore::Style::MatchedProperties, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
7   0x3ddd1aa0d WTF::Vector<WebCore::Style::MatchedProperties, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>::Vector(WTF::Vector<WebCore::Style::MatchedProperties, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
8   0x3ddd1a9e0 WebCore::Style::MatchResult::MatchResult(WebCore::Style::MatchResult const&)
9   0x3ddd1519d WebCore::Style::MatchResult::MatchResult(WebCore::Style::MatchResult const&)
10  0x3ddd15056 WebCore::Style::MatchedDeclarationsCache::add(WebCore::RenderStyle const&, WebCore::RenderStyle const&, unsigned int, WebCore::Style::MatchResult const&)
11  0x3ddd71e8e WebCore::Style::Resolver::applyMatchedProperties(WebCore::Style::Resolver::State&, WebCore::Style::MatchResult const&, WebCore::Style::Resolver::UseMatchedDeclarationsCache)
12  0x3ddd709ab WebCore::Style::Resolver::styleForElement(WebCore::Element const&, WebCore::RenderStyle const*, WebCore::RenderStyle const*, WebCore::RuleMatchingBehavior, WebCore::SelectorFilter const*)
13  0x3dc2ca424 WebCore::Element::resolveStyle(WebCore::RenderStyle const*)
14  0x3dde53661 WebCore::SVGElement::resolveCustomStyle(WebCore::RenderStyle const&, WebCore::RenderStyle const*)
15  0x3ddd8c5a6 WebCore::Style::TreeResolver::styleForStyleable(WebCore::Styleable const&, WebCore::RenderStyle const&)
16  0x3ddd8cbca WebCore::Style::TreeResolver::resolveElement(WebCore::Element&)
17  0x3ddd8f46c WebCore::Style::TreeResolver::resolveComposedTree()
18  0x3ddd902d2 WebCore::Style::TreeResolver::resolve()
19  0x3dc1e6b07 WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType)
20  0x3dc1e7720 WebCore::Document::updateStyleIfNeeded()

Debugging suggests this is matchResult.authorDeclarations.

Nothing shrinks the vectors in the m_entries.add() Entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210403/cf82df45/attachment.htm>