[Webkit-unassigned] [Bug 224014] [Win][WK2] Implement IPC::Semaphore to run WebGL in GPU process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224014

--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 424814
  --> https://bugs.webkit.org/attachment.cgi?id=424814
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424814&action=review

Great stuff. I know it's WIP, just some ideas.

> Source/WebKit/Platform/IPC/win/IPCSemaphoreWin.cpp:46
> +        m_semaphoreHandle = CreateSemaphoreA(nullptr, 0, 1, getSemaphoreName(m_semaphoreNumber).data());

Would be great if you investigated if it's possible to create a nameless semaphore and then duplicate handle it to the other process.
I think the support already might exist in AttachmentWin.

> Source/WebKit/Platform/IPC/win/IPCSemaphoreWin.cpp:87
> +    ReleaseSemaphore(m_semaphoreHandle, 1, nullptr);

These could assert maybe that the result is somehow expected

> Source/WebKit/Platform/IPC/win/IPCSemaphoreWin.cpp:119
> +        CloseHandle(m_semaphoreHandle);

need to clear the handle after this

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210401/33a5251b/attachment.htm>