[Webkit-unassigned] [Bug 217079] REGRESSION(r259582): Build fails on aarch64 Linux with WebKit 2.30.1 on LLIntOffsetsExtractor.cpp.o

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217079

--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Mark Lam from comment #11) 
> I think the real fix for this should be to ensure that all the support for
> the ASSEMBLER is not built in if none of the JITs are enabled.

I notice there are only a few ENABLE(JIT) guards under Source/JavaScriptCore/assembler:

$ git grep 'ENABLE(JIT)'
MacroAssemblerCodeRef.h:#if CPU(ARM_THUMB2) && ENABLE(JIT)
testmasm.cpp:#if ENABLE(JIT)
testmasm.cpp:#else // not ENABLE(JIT)
testmasm.cpp:#endif // ENABLE(JIT)

I also notice we have, in PlatformEnable.h:

/* If either the JIT or the RegExp JIT is enabled, then the Assembler must be
   enabled as well: */
#if ENABLE(JIT) || ENABLE(YARR_JIT) || !ENABLE(C_LOOP)
#if defined(ENABLE_ASSEMBLER) && !ENABLE_ASSEMBLER
#error "Cannot enable the JIT or RegExp JIT without enabling the Assembler"
#else
#undef ENABLE_ASSEMBLER
#define ENABLE_ASSEMBLER 1
#endif
#endif

So we could just remove || !ENABLE(C_LOOP) from the first line, and remove the test from MacroAssemblerCodeRef.h. (testmasm.cpp is built regardless of whether JIT is enabled.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200930/2bc476a0/attachment.htm>