[Webkit-unassigned] [Bug 217123] [GTK] Chassis type check fails if the value is quoted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 30 06:07:15 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=217123

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com
 Attachment #410108|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 410108
  --> https://bugs.webkit.org/attachment.cgi?id=410108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410108&action=review

> Source/WTF/wtf/glib/ChassisType.cpp:51
> +            if (error.get() != nullptr)

Do not compare to nullptr, and you don't need the .get() either:

if (error)
    g_warning();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200930/194b96aa/attachment.htm>


More information about the webkit-unassigned mailing list