[Webkit-unassigned] [Bug 189164] Document.p.contains returns true for nodes in shadow tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189164

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |darin at apple.com
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=216656
         Resolution|---                         |CONFIGURATION CHANGED

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Ah, okay, I know what happened there. Darin fixed this in https://trac.webkit.org/r267220.

Node::isDescendantOf has a special code for when "other" node is a document node.

Before r267220, we had the following code, which incorrectly assumed that any node which is connected to "other" is a descendent of "other":
    if (other.isDocumentNode())
        return &document() == &other && !isDocumentNode() && isConnected();

After r267220, now correctly checks that the root node of the current tree is same as "other":
    if (other.isDocumentNode())
        return &treeScope().rootNode() == &other && !isDocumentNode() && isConnected();

I expect this bug will be fixed the next STP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200928/798a530c/attachment-0001.htm>