[Webkit-unassigned] [Bug 149551] [SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149551

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #409698|review?                     |review+
              Flags|                            |

--- Comment #31 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 409698
  --> https://bugs.webkit.org/attachment.cgi?id=409698
Patch

Well... surprise. Any idea why this isn't broken for Safari?

Looking for other suspicious cases,there are a lot of places where we call setFirstPartyForCookies but not addSameSiteInfoToRequestIfNeeded: WebKitWebSourceGStreamer.cpp, SWServer.cpp, XSLTProcessor.cpp, NetworkCacheSpeculativeLoadManager.cpp, NetworkDataTaskCocoa.mm, NetworkDataTaskSoup.cpp, and WebProcessPool.cpp. I wonder how many of these are similar bugs and how many are covered by FrameLoader?

I also wonder why cookie_is_valid_for_same_site_policy() isn't causing this problem? We probably still need to look closer at that....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200925/7b4a2619/attachment-0001.htm>