[Webkit-unassigned] [Bug 216834] [macOS] Issue sandbox extension for the diagnostic daemon

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216834

--- Comment #7 from Per Arne Vollan <pvollan at apple.com> ---
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 409385 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409385&action=review
> 
> r=me, but I think you could use an existing FileSystem function instead of
> the raw 'stat' operation.
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:68
> > +#import <sys/stat.h>
> 
> You don't need to include this if you use , FileSystem::fileIsDirectory
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:211
> > +    static bool isInternal = !stat("/AppleInternal", &st);
> 
> I think it might be better to do:
> 
> static bool isInternal = FileSystem::fileIsDirectory("/AppleInternal",
> FileSystem::ShouldFollowSymbolicLinks::No);

Will fix, thanks for reviewing!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200923/7c850ca0/attachment.htm>