[Webkit-unassigned] [Bug 216813] REGRESSION(r267383): fast/mediastream/getUserMedia-webaudio.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216813

--- Comment #6 from Víctor M. Jáquez L. <vjaquez at igalia.com> ---
(In reply to Chris Dumez from comment #5)
> Would anyone be able to try to following change to see if it helps?
> 
> diff --git a/Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
> b/Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
> index 213dd93d8540..21438f80aa1a 100644
> --- a/Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
> +++ b/Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
> @@ -113,8 +113,15 @@ void FFTFrame::multiply(const FFTFrame& frame)
>      const float* realP2 = frame2.realData();
>      const float* imagP2 = frame2.imagData();
>  
> +    float real0 = realP1[0];
> +    float imag0 = imagP1[0];
> +
>      size_t size = unpackedFFTDataSize(m_FFTSize);
>      VectorMath::zvmul(realP1, imagP1, realP2, imagP2, realP1, imagP1, size);
> +
> +    // Multiply the packed DC/nyquist component
> +    realP1[0] = real0 * realP2[0];
> +    imagP1[0] = imag0 * imagP2[0];
>  }
>  
>  void FFTFrame::doFFT(const float* data)

This patch, doing a preliminary test, seems to fix 

imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html
webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html
webaudio/Analyser/realtimeanalyser-freq-data.html
webrtc/audio-peer-connection-webaudio.html
webrtc/peer-connection-audio-unmute.html

But not fast/mediastream/getUserMedia-webaudio.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200923/cbcd41ce/attachment.htm>