[Webkit-unassigned] [Bug 214230] font-weight should always serialize as a number

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214230

--- Comment #6 from Tyler Wilcock <twilco.o at protonmail.com> ---
This patch has resulted in pixel test changes that I'm not sure are right.

For example, look at the layout test results for ios-wk2 [1].  In the text snapshot of `editing/pasteboard/3976872.html` [2], <span>s are now being generated instead of <b>s, which in itself is not necessarily incorrect, assuming the span is styled correctly.  But in the image diff [3], the result box now ends up being highlighted.  This actually matches Chromium's behavior for this test.

One that certainly seems incorrect, though, is `editing/pasteboard/paste-match-style-001.html`, where the image diff [4] shows a space has been added between the 'a' and the 'b' characters.  The text diff [5] shows both a <b> *and* a <span> are being generated.  Interestingly, neither Chromium nor Gecko render the 'b' character at all for this test.

It seems like these inconsistencies are all related to usage of https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand, which is apparently deprecated.  Should I just update the expected results with these new ones, or do we need to dig deeper on any of these?


[1]: https://ews-build.s3-us-west-2.amazonaws.com/iOS-13-Simulator-WK2-Tests-EWS/r409107-26225/results.html

[2]: https://ews-build.s3-us-west-2.amazonaws.com/iOS-13-Simulator-WK2-Tests-EWS/r409107-26225/editing/pasteboard/3976872-pretty-diff.html

[3]: https://ews-build.s3-us-west-2.amazonaws.com/iOS-13-Simulator-WK2-Tests-EWS/r409107-26225/retries/editing/pasteboard/3976872-diffs.html

[4]: https://ews-build.s3-us-west-2.amazonaws.com/iOS-13-Simulator-WK2-Tests-EWS/r409107-26225/retries/editing/pasteboard/paste-match-style-001-diffs.html

[5]: https://ews-build.s3-us-west-2.amazonaws.com/iOS-13-Simulator-WK2-Tests-EWS/r409107-26225/editing/pasteboard/paste-match-style-001-pretty-diff.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200918/ad4ffe00/attachment-0001.htm>