[Webkit-unassigned] [Bug 216705] New: make ews-app robust against config.json issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216705

            Bug ID: 216705
           Summary: make ews-app robust against config.json issues
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

If config.json is invalid temporarily (e.g.: merge conflict while updating checkout on the buildbot server), then the ews-app might encounter a crash and stop polling for new patches. I noticed this on UAT instance. Noticed this exception in logs:

2020-09-17 20:51:17,020 - 22 r? patches, 0 patches need to be sent to Buildbot: []
2020-09-17 20:51:47,050 - Fetching: https://ews-build.webkit-uat.org/config.json
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/threading.py", line 812, in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.7/threading.py", line 765, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py", line 50, in run
    Buildbot.update_icons_for_queues_mapping()
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py", line 99, in update_icons_for_queues_mapping
    config = cls.fetch_config()
  File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py", line 95, in fetch_config
    return config_data.json()
  File "/usr/lib/python2.7/site-packages/requests/models.py", line 795, in json 
    return json.loads(self.content.decode(encoding), **kwargs)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting property name enclosed in double quotes: line 358 column 1 (char 6271)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200918/79ac672a/attachment.htm>