[Webkit-unassigned] [Bug 216624] WKPageLoadURLRequestReturningNavigation should allow opening universal links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216624

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408989
  --> https://bugs.webkit.org/attachment.cgi?id=408989
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408989&action=review

> Source/WebCore/loader/FrameLoaderTypes.h:141
> +    // Don't allow external URLs.
>      ShouldNotAllow,
> +    // External schemes are allowed but App Links are not.
>      ShouldAllowExternalSchemes,
> +    // Allow external URLs.
>      ShouldAllow,

Please revise the names instead of adding comments. We want these names clear everywhere they are used, not just when reading this header.

    ShouldAllowExternalSchemesButNotAppLinks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200917/64ffbfd6/attachment.htm>