[Webkit-unassigned] [Bug 216591] REGRESSION(r266677): ASSERTION FAILED in PaintFrequencyTracker::end()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216591

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wenson_hsieh at apple.com

--- Comment #1 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Said Abou-Hallawa from comment #0)
> Painting RenderLayers can be called from code paths which do not schedule
> RenderingUpdate through RenderingUpdateScheduler. This means
> RenderLayer::paintLayerContents() may be called while
> Page::updateRendering() is not on the call stack. This will make
> timestampForPaintFrequencyTracking() returns zero in this case. So
> PaintFrequencyTracker::end() will fail the assertion
> ASSERT(m_firstPaintTime). An example for this case is taking a snapshot of
> the page, or calling FrameView::paintContentsForSnapshot(). Another example
> is updating control tints or calling FrameView::updateControlTints().

To clarify — `timestampForPaintFrequencyTracking()` will only return 0 if `Page::updateRendering()` has never been called (not if `RenderLayer::paintLayerContents()` is called while `Page::updateRendering()` is not on the call stack).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200916/315efa58/attachment.htm>