[Webkit-unassigned] [Bug 215974] Wrong error message of the spread.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 12 15:16:05 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=215974

--- Comment #7 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 408597
  --> https://bugs.webkit.org/attachment.cgi?id=408597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408597&action=review

Thank you for submitting the patch. I've left a comment on the approach.

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:1577
> +        if (UNLIKELY(scope.exception())) {

We can't override an exception as it won't necessarily be an unhelpful "undefined is not a function" one; it could be a userland-thrown error.
Instead, we should fix `iterationFunction`, which is defined in Source/JavaScriptCore/builtins/IteratorHelpers.js.
While we do that, we need to make sure Symbol.iterator is looked up only once.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200912/b4c911cd/attachment.htm>


More information about the webkit-unassigned mailing list