[Webkit-unassigned] [Bug 216397] [GTK] Timeouts after reftest-wait class enablement in r266817

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 14:15:40 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=216397

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #408530|review?                     |review+
              Flags|                            |

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 408530
  --> https://bugs.webkit.org/attachment.cgi?id=408530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408530&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1971
> +        RunLoop::current().dispatchAfter(1_ms, [] {

Usually we frown upon timers in testing code, but given that the reason
here is to make sure other things run and that the timeout is small and
unlikely to cause tests to run more slowly, I am willing to accept this
=]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200911/3898e9fc/attachment.htm>


More information about the webkit-unassigned mailing list