[Webkit-unassigned] [Bug 216355] Don't create event regions when the page has no subscrollers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216355

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #408432|review?                     |review+
              Flags|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408432
  --> https://bugs.webkit.org/attachment.cgi?id=408432
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408432&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:39
> +    scrollingStateTree().scrollingNodeAdded();

I wonder if ScrollingStateTree::addNode() is a better place to call this.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:80
> +    scrollingStateTree().scrollingNodeRemoved();

I wonder if ScrollingStateTree::willRemoveNode() is a better place to call this.

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:880
>> +            invalidateEventRegionForAllFrames();
> 
> I don't like that this triggers a second compositing update just after we've finished one, and in all frames too!
> 
> This means that every page with one or more subscrollers now suffers from an extra full layer tree walk in all frames and a second compositing update.

I see now that we'll update regions at the end of the rendering update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200910/517925be/attachment.htm>